A developer's piece of code was posted in the wall of shame. It was a horrible piece of code and should have been refactored to one line of code. No one has ever conducted a code review or spoken to the developer to show what was done wrong.
I asked if anyone had ever told the developer what was wrong with the piece of code (I prefer people telling me where have I done wrong) but no one had and the answer was we have never done code review.
The senior developer said that everyone is responsible for his code. and this is where I disagree.
I know we have just started to adopt Agile methodologies and we are far away from it yet but a couple of people on the team including the senior developer and manager have experience with Agile projects.... so this came in mind:
- Collective code ownership. Take as much pride in the team's code as in your own code.
- Always leave the code a little better than you found it.
- Fix problems no matter where you find them.
Everyone on the project shares the responsibility for the quality of the code. Developers are expected to be able to refactor code and fix the problems they find. Everyone should see the team's code as their own. If a developer needs help or is not doing his job properly, this might be a good time to use code review and pair programming to spot the problem and educate the person. After all, it's not about processes and methods.. it's about people.
Or not?
No comments:
Post a Comment